[Mesa-dev] [PATCH 1/2] spirv: don't assert with location decorations on non i/o variables

Lionel Landwerlin lionel.g.landwerlin at intel.com
Fri Jan 20 21:53:09 UTC 2017


On 20/01/17 20:40, Dave Airlie wrote:
> On 21 January 2017 at 03:08, Jason Ekstrand <jason at jlekstrand.net> wrote:
>> On Fri, Jan 20, 2017 at 8:45 AM, Lionel Landwerlin
>> <lionel.g.landwerlin at intel.com> wrote:
>>> Some applications might add location decoration to samplers. Rather
>>> than raising an error it seems it would make more sense to just
>>> discard these decorations.
>>
>> That's annoying but not the end of the world.  Please CC to 17.0 stable (but
>> not 13.0)  Also, please try and file a bug with the Unit3D people as this is
>> a bug in their SPIR-V generator.
> I came across this a while ago and reported it via Valve.
>
> I'm not sure where it got to, I had a patch that did much the same as this.
>
> Maybe we should consider a mesa spir-v bugs layer to rewrite incoming
> spir-v bugs before the driver.
>
> Dave.
>

I'm trying to raise the issue with the debug layers : 
https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers/issues/1378
We'll see where that leads.

-
Lionel


More information about the mesa-dev mailing list