[Mesa-dev] [PATCH 0/7] i965: Implement EGL_ANDROID_native_fence_sync

Rafael Antognolli rafael.antognolli at intel.com
Fri Jan 20 22:03:09 UTC 2017


I have tested this series with the branches that you mentioned, and with
piglit with the patches from my own branch:

https://github.com/rantogno/piglit/tree/review/fences-v02

Everything seems to work fine. You can add:

Tested-by: Rafael Antognolli <rafael.antognolli at intel.com>

I also have gone through these patches several times while they were
under development, and they look good to me. So if you disregard my
shallow knowledge of Mesa, you could add:

Reviewed-by: Rafael Antognolli <rafael.antognolli at intel.com>

Thanks,
Rafael

On Fri, Jan 13, 2017 at 10:51:27AM -0800, Chad Versace wrote:
> This series depends on fence fd support in I915_GEM_EXECBUFFER2, which
> isn't upstream in libdrm nor the kernel yet.  I tested this with kmscube
> on Skylake, and everything looked good to me.
> 
> I pushed tags for this series as well as all the code I tested with:
> 
>     mesa: http://git.kiwitree.net/cgit/~chadv/mesa/tag/?h=chadv/review/i965-exec-fence-v03
>     libdrm: http://git.kiwitree.net/cgit/~chadv/libdrm/tag/?h=chadv/review/intel-exec-fence-v01
>     linux: http://git.kiwitree.net/cgit/~chadv/linux/tag/?h=chadv/test/i915-exec-fence-v03
>     kmscube: http://git.kiwitree.net/cgit/~chadv/kmscube/tag/?h=chadv/test/fences-v02
> 
> I submitted the libdrm patches to the intel-gfx list. Someone else
> should submit the kernel patches, as I tested them but don't grok them.
> 
> Chad Versace (7):
>   i965: Add intel_screen::has_fence_fd
>   i965: Add intel_batchbuffer_flush_fence()
>   i965/sync: Add brw_fence::type
>   i965/sync: Fail sync creation when batchbuffer flush fails
>   i965/sync: Rename brw_fence_insert()
>   WAIT: configure: Bump libdrm requirement to 2.4.XX
>   i965/sync: Implement fences based on Linux sync_file
> 
>  configure.ac                                  |   3 +-
>  src/mesa/drivers/dri/i965/brw_sync.c          | 293 ++++++++++++++++++++++----
>  src/mesa/drivers/dri/i965/intel_batchbuffer.c |  24 ++-
>  src/mesa/drivers/dri/i965/intel_batchbuffer.h |  14 +-
>  src/mesa/drivers/dri/i965/intel_screen.c      |   3 +
>  src/mesa/drivers/dri/i965/intel_screen.h      |   2 +-
>  6 files changed, 287 insertions(+), 52 deletions(-)
> 
> -- 
> 2.11.0.21.ga274e0a
> 


More information about the mesa-dev mailing list