[Mesa-dev] [PATCH V3] glsl: lower constant arrays to uniform arrays before optimisation loop

[Eric Anholt]

Timothy Arceri <t_arceri at yahoo.com.au> writes:

> From: Timothy Arceri <timothy.arceri at collabora.com>
>
> Previously the constant array would not get copy propagated until the backend
> did its GLSL IR opt loop. I plan on removing that from i965 shortly which
> caused huge regressions in Deus-ex and Tomb Raider which have large
> constant arrays. Moving lowering before the opt loop in the GLSL linker
> fixes this and unexpectedly improves some compute shaders also.

It seems like we should figure out what's missing in NIR that the lack
of GLSL copy propagation hurt, but this is a pretty easy fix for now:

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170124/ce855afd/attachment.sig>