[Mesa-dev] [PATCH] i965: Use a UW source type for CS_OPCODE_CS_TERMINATE.

[Francisco Jerez]

Matt Turner <mattst88 at gmail.com> writes:

> On Tue, Jan 24, 2017 at 2:18 PM, Kenneth Graunke <kenneth at whitecape.org> wrote:
>> SIMD16 compute shaders use a send(16) with mlen 1 for the EOT message,
>> using a source of g127 for the single register.  With a UD type, this
>> supposedly could read g128, which doesn't exist, causing the simulator
>> to get cranky.  Use a UW type to avoid this.
>
> Bizarre. Is the hardware this stupid, or just the simulator?

I doubt the hardware would care, but I guess it wouldn't hurt to do this
in order to make the simulator happy.  How about we fix this in the
generator instead for consistency with the other send-message UW
register retyping workarounds?  Assuming you apply the same fix in
fs_generator::generate_cs_terminate instead patch is:

Reviewed-by: Francisco Jerez <currojerez at riseup.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 212 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170124/fc88dddc/attachment-0001.sig>