[Mesa-dev] [PATCH 0/5] anv: Implement VK_KHR_get_physical_device_properties2 (v2)

[Lionel Landwerlin]

Looks good to me :

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>

On 25/01/17 20:12, Chad Versace wrote:
> Untested, but builds. I wanted to get feedback on this approach before
> going through the trouble of fetching and building the newest CTS. If
> the review feedback is good, then I'll test it with the CTS.

You'll need an updated loader too

>
> Pushed as tag 'chadv/review/anv-VK_KHR_get_physical_device_properties2-v02'
> in my repo:
>
>    http://git.kiwitree.net/cgit/~chadv/mesa/tag/?h=chadv/review/anv-VK_KHR_get_physical_device_properties2-v02
>
> v2:
>    - Iterate over each pNext chain, as suggested by Jason, even though we
>      don't support any extension structs yet.
>    - Print a debug message for each ignored struct in the pNext chain
>      (which is all of them currently currently).
>
> Chad Versace (5):
>    anv: Define macro anv_debug()
>    anv: Revive struct anv_common
>    anv: Refactor anv_GetPhysicalDeviceFormatProperties()
>    anv: Refactor anv_GetPhysicalDeviceQueueFamilyProperties()
>    anv: Implement VK_KHR_get_physical_device_properties2
>
>   src/intel/vulkan/anv_device.c  | 116 ++++++++++++++++++++++++++++++++++---
>   src/intel/vulkan/anv_formats.c | 126 ++++++++++++++++++++++++++++++++---------
>   src/intel/vulkan/anv_private.h |  25 ++++++++
>   3 files changed, 232 insertions(+), 35 deletions(-)
>