[Mesa-dev] [PATCH 4/7] intel/blorp: Silently convert RGBX destination formats to RGBA

[Pohjolainen, Topi]

On Tue, Jan 24, 2017 at 03:45:51PM -0800, Jason Ekstrand wrote:
> ---
>  src/intel/blorp/blorp_blit.c | 4 ++++
>  1 file changed, 4 insertions(+)

Patches 3 and 4 are:

Reviewed-by: Topi Pohjolainen <topi.pohjolainen at intel.co>

Patch 2 looks good also. I just need to study the E9-math some more. Although
I may not be the best person to review it...

> 
> diff --git a/src/intel/blorp/blorp_blit.c b/src/intel/blorp/blorp_blit.c
> index b964224..4d8942e 100644
> --- a/src/intel/blorp/blorp_blit.c
> +++ b/src/intel/blorp/blorp_blit.c
> @@ -1883,6 +1883,10 @@ try_blorp_blit(struct blorp_batch *batch,
>  
>        wm_prog_key->dst_rgb = true;
>        wm_prog_key->need_dst_offset = true;
> +   } else if (isl_format_is_rgbx(params->dst.view.format)) {
> +      /* We can handle RGBX formats easily enough by treating them as RGBA */
> +      params->dst.view.format =
> +         isl_format_rgbx_to_rgba(params->dst.view.format);
>     } else if (params->dst.view.format == ISL_FORMAT_R24_UNORM_X8_TYPELESS) {
>        wm_prog_key->dst_format = params->dst.view.format;
>        params->dst.view.format = ISL_FORMAT_R32_UNORM;
> -- 
> 2.5.0.400.gff86faf
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev