[Mesa-dev] [PATCH 2/8] nir: add extra const notation in compare_blocks()

Jason Ekstrand jason at jlekstrand.net
Thu Jan 26 18:22:00 UTC 2017


LGTM

On Thu, Jan 26, 2017 at 6:05 AM, Lionel Landwerlin <
lionel.g.landwerlin at intel.com> wrote:

> Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
>
> On 26/01/17 13:18, Emil Velikov wrote:
>
>> From: Emil Velikov <emil.velikov at collabora.com>
>>
>> MSVC warns about different const qualifiers. Add the extra const to
>> silence it.
>>
>> nir_phi_builder.c(244) : warning C4090: 'initializing' : different
>> 'const' qualifiers
>> nir_phi_builder.c(245) : warning C4090: 'initializing' : different
>> 'const' qualifiers
>>
>> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
>> ---
>>   src/compiler/nir/nir_phi_builder.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/src/compiler/nir/nir_phi_builder.c
>> b/src/compiler/nir/nir_phi_builder.c
>> index acfc771da2..883884bb7f 100644
>> --- a/src/compiler/nir/nir_phi_builder.c
>> +++ b/src/compiler/nir/nir_phi_builder.c
>> @@ -241,8 +241,8 @@ nir_phi_builder_value_get_block_def(struct
>> nir_phi_builder_value *val,
>>   static int
>>   compare_blocks(const void *_a, const void *_b)
>>   {
>> -   nir_block * const * a = _a;
>> -   nir_block * const * b = _b;
>> +   const nir_block * const * a = _a;
>> +   const nir_block * const * b = _b;
>>        return (*a)->index - (*b)->index;
>>   }
>>
>
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170126/c6fb7a68/attachment-0001.html>


More information about the mesa-dev mailing list