[Mesa-dev] [PATCH 8/8] nouveau: let .get_name() append LLVM if built with LLVM

[Ilia Mirkin]

On Fri, Jan 27, 2017 at 12:16 PM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> On 26 January 2017 at 19:46, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
>> Yeah, I'd much prefer this to be
>>
>> if (nouveau_screen(pscreen)->class_3d < NV50_3D_CLASS)
>>   llvm = " LLVM";
>>
>> or something along those lines. [Using dev->chipset will be annoying
>> since nv50 = 0x50, and nv67 (nv4x) = 0x67.]
>>
> I was about to go for either the logic we have in nouveau_drm_winsys.c
> or having the callback set by the nvX_screen_create as opposed to
> nouveau_screen_create.
>
> Would either of those be ok, or you'd prefer the 3D_CLASS check ?

I was suggesting the class check for simplicity. Any other logic you'd
like to implement is fine by me.