[Mesa-dev] [PATCH 23/29] radv: add pipeline creation support for geometry shaders (v2)

[Dave Airlie]

On 30 January 2017 at 16:02, Dave Airlie <airlied at gmail.com> wrote:
> From: Dave Airlie <airlied at redhat.com>
>
> This adds gs copy shader support to the pipeline cache, and few
> geometry related changes.

There is a minor rebase bug in this, I've fixed it in my
radv-geom-shader-submit branch,.


>
> v2: rebase for spill changes.
>
> Signed-off-by: Dave Airlie <airlied at redhat.com>
> ---
>  src/amd/vulkan/radv_pipeline.c       | 128 +++++++++++++++++++++++++++++++++--
>  src/amd/vulkan/radv_pipeline_cache.c |   4 +-
>  src/amd/vulkan/radv_private.h        |   4 +-
>  3 files changed, 128 insertions(+), 8 deletions(-)
>
> diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c
> index f46987f..da8f561 100644
> --- a/src/amd/vulkan/radv_pipeline.c
> +++ b/src/amd/vulkan/radv_pipeline.c
> @@ -128,6 +128,13 @@ void radv_DestroyPipeline(
>         if (!_pipeline)
>                 return;
>
> +       for (unsigned i = 0; i < MESA_SHADER_STAGES; ++i)
> +               if (pipeline->shaders[i])
> +                       radv_shader_variant_destroy(device, pipeline->shaders[i]);
> +
> +       if (pipeline->gs_copy_shader)
> +               radv_shader_variant_destroy(device, pipeline->gs_copy_shader);
> +
>         radv_pipeline_destroy(device, pipeline, pAllocator);


^^ this is incorrect, and fixed in v2.1

Dave.