[Mesa-dev] [PATCH 1/2] radv: Don't allow any operations on non-supported depth/stencil formats.

[Andres Rodriguez]

Reviewed-by: Andres Rodriguez <andresx7 at gmail.com>


On 2017-01-25 06:24 PM, Bas Nieuwenhuizen wrote:
> We really use the depth block for the blits.
>
> Signed-off-by: Bas Nieuwenhuizen <basni at google.com>
> ---
>   src/amd/vulkan/radv_formats.c | 9 +++++----
>   1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/src/amd/vulkan/radv_formats.c b/src/amd/vulkan/radv_formats.c
> index e276432c2ee..f56f67c400e 100644
> --- a/src/amd/vulkan/radv_formats.c
> +++ b/src/amd/vulkan/radv_formats.c
> @@ -565,11 +565,12 @@ radv_physical_device_get_format_properties(struct radv_physical_device *physical
>   	}
>   
>   	if (vk_format_is_depth_or_stencil(format)) {
> -		if (radv_is_zs_format_supported(format))
> +		if (radv_is_zs_format_supported(format)) {
>   			tiled |= VK_FORMAT_FEATURE_DEPTH_STENCIL_ATTACHMENT_BIT;
> -		tiled |= VK_FORMAT_FEATURE_SAMPLED_IMAGE_BIT;
> -		tiled |= VK_FORMAT_FEATURE_BLIT_SRC_BIT |
> -			VK_FORMAT_FEATURE_BLIT_DST_BIT;
> +			tiled |= VK_FORMAT_FEATURE_SAMPLED_IMAGE_BIT;
> +			tiled |= VK_FORMAT_FEATURE_BLIT_SRC_BIT |
> +			         VK_FORMAT_FEATURE_BLIT_DST_BIT;
> +		}
>   	} else {
>   		bool linear_sampling;
>   		if (radv_is_sampler_format_supported(format, &linear_sampling)) {