[Mesa-dev] [PATCH v4] android: add vulkan build for intel

[Tapani Pälli]

On 01/31/2017 08:38 AM, Jason Ekstrand wrote:
>
>
> On Jan 30, 2017 10:03 PM, "Tapani Pälli" <tapani.palli at intel.com
> <mailto:tapani.palli at intel.com>> wrote:
>
>
>
>     On 01/30/2017 04:00 PM, Emil Velikov wrote:
>
>         On 30 January 2017 at 11:37, Tapani Pälli
>         <tapani.palli at intel.com <mailto:tapani.palli at intel.com>> wrote:
>
>             fixes to issues spotted by Emil Velikov:
>
>                - set ANV_TIMESTAMP corretly
>                - fix typo with VULKAN_GEM_FILES
>
>             v2: update to use Makefile.sources under vulkan
>                 instead of having own
>
>             v3: update to changes to generate from vk.xml
>                 (commit c7fc310)
>
>             v4: remove 'hw' relative path
>                 cleanups, remove unnecessary cruft
>
>                 review from Emil Velikov:
>
>                 - move to vulkan folder
>                 - remove timestamp gen, no longer necessary
>                 - more cleanups
>
>         Reviewed-by: Emil Velikov <emil.velikov at collabora.com
>         <mailto:emil.velikov at collabora.com>>
>
>         Does one need the VK_USE_PLATFORM_ANDROID_KHR
>         define/VK_KHR_ANDROID_SURFACE_EXTENSION_NAME/winsys
>         implementation or
>         the vulkan HAL is enough ?
>
>
>     We need some more implementation and probably the define but I
>     wanted to leave this enabling later as this needs some more
>     investigation. We do currently pass following tests:
>
>     dEQP-VK.wsi.android.surface.cr
>     <http://dEQP-VK.wsi.android.surface.cr>eate
>     dEQP-VK.wsi.android.surface.cr
>     <http://dEQP-VK.wsi.android.surface.cr>eate_custom_allocator
>     dEQP-VK.wsi.android.surface.query_support
>     dEQP-VK.wsi.android.surface.query_capabilities
>     dEQP-VK.wsi.android.surface.query_formats
>     dEQP-VK.wsi.android.surface.query_present_modes
>     dEQP-VK.wsi.android.surface.in
>     <http://dEQP-VK.wsi.android.surface.in>itial_size
>
>     but we get 'Duplicate extensions' failure from
>     dEQP-VK.api.info.instance.extensions and I can see that
>     'VK_KHR_surface' and 'VK_KHR_android_surface' are 2 times in the
>     extensions list, I don't understand why but will try to figure this out.
>
>
> No idea if this helps but there were some older versions of the loader
> that had a bug where they would search some paths twice and accidentally
> have duplicate extension names show up.  I'm not sure how android
> expects those extensions to be implemented but it could be that both the
> driver and the android loader are implementing them.  Just a drive-by
> thought.

So this could be possibly a loader bug as well, I've noticed that it has 
not been updated for a long time (at least in the code base that we have).

According to docs "VK_KHR_surface, VK_KHR_android_surface, and 
VK_KHR_swapchain are implemented by the platform and live in 
libvulkan.so". So in theory the functions we provide from vulkan HAL 
module should be 'enough' to get things going.

https://source.android.com/devices/graphics/implement-vulkan.html#wsi

// Tapani