[Mesa-dev] [PATCH] mesa: Implement ARB_texture_filter_minmax for i965/gen9+

[Ilia Mirkin]

On Tue, Jan 31, 2017 at 1:53 PM, Plamena Manolova
<plamena.manolova at intel.com> wrote:
> This extension provides a new texture and sampler parameter
> (TEXTURE_REDUCTION_MODE_ARB) which allows applications to produce a
> filtered texel value by computing a component-wise minimum (MIN) or
> maximum (MAX) of the texels that would normally be averaged.  The
> reduction mode is orthogonal to the minification and magnification filter
> parameters.  The filter parameters are used to identify the set of texels
> used to produce a final filtered value; the reduction mode identifies how
> these texels are combined.
> <https://www.opengl.org/registry/specs/ARB/texture_filter_minmax.txt>\

That link gives me a 404.

>
> Signed-off-by: Plamena Manolova <plamena.manolova at intel.com>
> ---
>  docs/features.txt                             |  2 +-
>  docs/relnotes/17.0.0.html                     |  1 +
>  src/mesa/drivers/dri/i965/brw_defines.h       |  8 +++
>  src/mesa/drivers/dri/i965/brw_sampler_state.c | 31 ++++++++++--
>  src/mesa/drivers/dri/i965/brw_state.h         |  3 +-
>  src/mesa/drivers/dri/i965/intel_extensions.c  |  1 +
>  src/mesa/main/extensions_table.h              |  1 +
>  src/mesa/main/mtypes.h                        |  2 +
>  src/mesa/main/samplerobj.c                    | 71 +++++++++++++++++++++++++++
>  src/mesa/main/texobj.c                        |  1 +
>  src/mesa/main/texparam.c                      | 35 +++++++++++++
>  11 files changed, 151 insertions(+), 5 deletions(-)
>
> diff --git a/docs/features.txt b/docs/features.txt
> index aff0016..da9d77a 100644
> --- a/docs/features.txt
> +++ b/docs/features.txt
> @@ -302,7 +302,7 @@ Khronos, ARB, and OES extensions that are not part of any OpenGL or OpenGL ES ve
>    GL_ARB_sparse_texture                                 not started
>    GL_ARB_sparse_texture2                                not started
>    GL_ARB_sparse_texture_clamp                           not started
> -  GL_ARB_texture_filter_minmax                          not started
> +  GL_ARB_texture_filter_minmax                          DONE (i965/gen9+)
>    GL_ARB_transform_feedback_overflow_query              not started
>    GL_KHR_blend_equation_advanced_coherent               DONE (i965/gen9+)
>    GL_KHR_no_error                                       not started
> diff --git a/docs/relnotes/17.0.0.html b/docs/relnotes/17.0.0.html
> index 71fb4c3..eb6341b 100644
> --- a/docs/relnotes/17.0.0.html
> +++ b/docs/relnotes/17.0.0.html

I think that ship has sailed. You want 17.1.0.html.

It's most common to split up the core and driver bits into separate
commits, with the core code coming in first.

Cheers,

  -ilia