[Mesa-dev] [PATCH 3/4] docs: avoid overwrite of LD_LIBRARY_PATH during basic testing

[Emil Velikov]

On 8 July 2017 at 20:59, Andres Gomez <agomez at igalia.com> wrote:
> The LD_LIBRARY_PATH environment variable could be already defined so
> we extend it and restore it rather than just overwriting it.
>
Hmm, what are you doing to actually require LD_LIBRARY_PATH in the first place?
It makes it somewhat uneasy that one will have that in their setup.

> Signed-off-by: Andres Gomez <agomez at igalia.com>
> ---
>  docs/releasing.html | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/docs/releasing.html b/docs/releasing.html
> index 8e6e4d1a6d..99235d8412 100644
> --- a/docs/releasing.html
> +++ b/docs/releasing.html
> @@ -472,7 +472,8 @@ Here is one solution that I've been using.
>         __glxgears_cmd='glxgears 2>&1 | grep -v "configuration file"'
>         __es2info_cmd='es2_info 2>&1 | egrep "GL_VERSION|GL_RENDERER|.*dri\.so"'
>         __es2gears_cmd='es2gears_x11 2>&1 | grep -v "configuration file"'
> -       export LD_LIBRARY_PATH=`pwd`/test/usr/local/lib/
> +       'x$LD_LIBRARY_PATH' -ne 'x' && __old_ld='$LD_LIBRARY_PATH' && __token=':'
> +       export LD_LIBRARY_PATH=`pwd`/test/usr/local/lib/'${__token}${__old_ld}'
AFAICT you don't need __token.

-Emil