[Mesa-dev] [PATCH 3/4] docs: avoid overwrite of LD_LIBRARY_PATH during basic testing

[Andres Gomez]

On Mon, 2017-07-10 at 12:15 +0100, Eric Engestrom wrote:
> On Saturday, 2017-07-08 22:59:40 +0300, Andres Gomez wrote:
> > The LD_LIBRARY_PATH environment variable could be already defined so
> > we extend it and restore it rather than just overwriting it.
> > 
> > Signed-off-by: Andres Gomez <agomez at igalia.com>
> > ---
> >  docs/releasing.html | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/docs/releasing.html b/docs/releasing.html
> > index 8e6e4d1a6d..99235d8412 100644
> > --- a/docs/releasing.html
> > +++ b/docs/releasing.html
> > @@ -472,7 +472,8 @@ Here is one solution that I've been using.
> >  	__glxgears_cmd='glxgears 2>&1 | grep -v "configuration file"'
> >  	__es2info_cmd='es2_info 2>&1 | egrep "GL_VERSION|GL_RENDERER|.*dri\.so"'
> >  	__es2gears_cmd='es2gears_x11 2>&1 | grep -v "configuration file"'
> > -	export LD_LIBRARY_PATH=`pwd`/test/usr/local/lib/
> > +	'x$LD_LIBRARY_PATH' -ne 'x' && __old_ld='$LD_LIBRARY_PATH' && __token=':'
> 
> s/'/"/g across the patch
> 
> and you need `[ ]` around the tests

Ugh! I messed this patch big time. I intended to use "test" but quotes
and the test itself is wrong ... and I'd swear I checked copying and
pasting from the web page. Oh well ...

Thanks a lot for catching all this ☺

-- 
Br,

Andres