[Mesa-dev] [PATCH v2 08/27] main/formats: Autogenerate _mesa_get_srgb_format_linear

[Jason Ekstrand]

On Sat, Jul 8, 2017 at 11:38 AM, Chad Versace <chadversary at chromium.org>
wrote:

> On Thu 29 Jun 2017, Jason Ekstrand wrote:
> > ---
> >  src/mesa/main/format_fallback.py |  46 +++++++++++++++
> >  src/mesa/main/formats.c          | 117 ------------------------------
> ---------
> >  2 files changed, 46 insertions(+), 117 deletions(-)
> >
> > diff --git a/src/mesa/main/format_fallback.py b/src/mesa/main/format_
> fallback.py
> > index e3b9916..ec86938 100644
> > --- a/src/mesa/main/format_fallback.py
> > +++ b/src/mesa/main/format_fallback.py
> > @@ -38,6 +38,34 @@ def parse_args():
> >      p.add_argument("out")
> >      return p.parse_args()
> >
> > +def get_unorm_to_srgb_map(formats):
> > +    names = {fmt.name for fmt in formats}
>
> Set comprehenstions broke the build on CentOS. See
> commit 95731b7ccc605bbfe2c3cb3d533219bc0788cbaa.
>

Fixed.


> Also, please say in the commit message that the new function covers more
> formats than the originl. The additional formats covered by the new
> function are the 3D ASTC formats below:
>
> MESA_FORMAT_SRGB8_ALPHA8_ASTC_3x3x3
> MESA_FORMAT_SRGB8_ALPHA8_ASTC_4x3x3
> MESA_FORMAT_SRGB8_ALPHA8_ASTC_4x4x3
> MESA_FORMAT_SRGB8_ALPHA8_ASTC_4x4x4
> MESA_FORMAT_SRGB8_ALPHA8_ASTC_5x4x4
> MESA_FORMAT_SRGB8_ALPHA8_ASTC_5x5x4
> MESA_FORMAT_SRGB8_ALPHA8_ASTC_5x5x5
> MESA_FORMAT_SRGB8_ALPHA8_ASTC_6x5x5
> MESA_FORMAT_SRGB8_ALPHA8_ASTC_6x6x5
> MESA_FORMAT_SRGB8_ALPHA8_ASTC_6x6x6
>

Done.

With those two things fixed:
> Reviewed-by: Chad Versace <chadversary at chromium.org>
>

Thanks!
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170712/ce624c9a/attachment.html>