[Mesa-dev] [PATCH v3 03/14] i965/miptree: Replace is_lossless_compressed with mt->aux_usage checks

Chad Versace chadversary at chromium.org
Fri Jul 14 22:26:17 UTC 2017


On Wed 12 Jul 2017, Jason Ekstrand wrote:
> Now that we have an actual aux_usage field, we no longer need the
> complex logic of is_lossless_compressed in order to figure out if a
> miptree is CCS_E compressed.  As a side-effect, there is not longer any
> need to overload MSAA_LAYOUT_CMS for CCS_E and we can stop doing so.
> ---
>  src/mesa/drivers/dri/i965/brw_blorp.c            |  2 +-
>  src/mesa/drivers/dri/i965/brw_draw.c             |  2 +-
>  src/mesa/drivers/dri/i965/brw_wm_surface_state.c |  4 +--
>  src/mesa/drivers/dri/i965/intel_mipmap_tree.c    | 39 ++++--------------------
>  src/mesa/drivers/dri/i965/intel_mipmap_tree.h    |  4 ---
>  5 files changed, 10 insertions(+), 41 deletions(-)

Yes. This patch makes me feel more confident that this miptree code is
correct.

Reviewed-by: Chad Versace <chadversary at chromium.org>


More information about the mesa-dev mailing list