[Mesa-dev] [PATCH mesa] spirv: add missing include path

Jason Ekstrand jason at jlekstrand.net
Tue Jul 18 18:17:53 UTC 2017


On Tue, Jul 18, 2017 at 11:15 AM, Ian Romanick <idr at freedesktop.org> wrote:

> I can believe the fix, but I don't understand why it's necessary.
> spirv_info.c includes spriv_info.h in the same manner as before
> 2dd4e2ec, and, as far as I can understand, spirv_info.c gets built in
> the same way as before.  Can someone explain to me why it broke?
> ...because I don't want to break it again.
>

Out-of-tree builds.  In that case, spirv_info.c is in the build directory
but spirv_info.h is in the source directory.

--Jason


> On 07/18/2017 11:03 AM, Eric Engestrom wrote:
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101831
> > Signed-off-by: Eric Engestrom <eric.engestrom at imgtec.com>
> > ---
> >
> > Note: Android and SCons probably need a similar fix
> > ---
> >  src/compiler/Makefile.nir.am | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/src/compiler/Makefile.nir.am b/src/compiler/Makefile.nir.am
> > index 1533ee536d..002b9fc535 100644
> > --- a/src/compiler/Makefile.nir.am
> > +++ b/src/compiler/Makefile.nir.am
> > @@ -32,6 +32,9 @@ nir_libnir_la_SOURCES =
>      \
> >       $(SPIRV_GENERATED_FILES)                        \
> >       $(NIR_GENERATED_FILES)
> >
> > +nir_libnir_la_SOURCES = \
> > +     -I$(top_builddir)/src/compiler/spirv
> > +
> >  nir/nir_builder_opcodes.h: nir/nir_opcodes.py
> nir/nir_builder_opcodes_h.py
> >       $(MKDIR_GEN)
> >       $(PYTHON_GEN) $(srcdir)/nir/nir_builder_opcodes_h.py > $@ ||
> ($(RM) $@; false)
> >
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170718/b69a0675/attachment.html>


More information about the mesa-dev mailing list