[Mesa-dev] [PATCH 03/22] i965/miptree: Switch to isl_surf::tiling

Jason Ekstrand jason at jlekstrand.net
Tue Jul 18 20:36:14 UTC 2017


On Tue, Jul 18, 2017 at 1:30 PM, Kenneth Graunke <kenneth at whitecape.org>
wrote:

> On Tuesday, July 18, 2017 1:46:13 AM PDT Topi Pohjolainen wrote:
> [snip]
> > diff --git a/src/mesa/drivers/dri/i965/intel_blit.h
> b/src/mesa/drivers/dri/i965/intel_blit.h
> > index 5e4d1f5eb4..90514dc893 100644
> > --- a/src/mesa/drivers/dri/i965/intel_blit.h
> > +++ b/src/mesa/drivers/dri/i965/intel_blit.h
> > @@ -41,17 +41,32 @@ isl_tiling_to_bufmgr_tiling(enum isl_tiling tiling)
> >     return I915_TILING_NONE;
> >  }
> >
> > +static inline enum isl_tiling
> > +bufmgr_tiling_to_isl_tiling(unsigned tiling)
> > +{
> > +   switch (tiling) {
> > +   case I915_TILING_NONE:
> > +      return ISL_TILING_LINEAR;
> > +   case I915_TILING_X:
> > +      return ISL_TILING_X;
> > +   case I915_TILING_Y:
> > +      return ISL_TILING_Y0;
> > +   }
> > +
> > +   unreachable("Invalid tiling mode");
> > +}
> > +
>
> This doesn't appear to be used at this point.  If it's used later, great,
> but I'm not sure why you'd need a converter in this direction?
>

It's used in miptree_create_for_bo

Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170718/8983d160/attachment.html>


More information about the mesa-dev mailing list