[Mesa-dev] [PATCH 1/3] nir: NULL check lower_copies_to_load_store()

[Jason Ekstrand]

On Thu, Jun 29, 2017 at 7:45 PM, Timothy Arceri <tarceri at itsqueeze.com>
wrote:

> Allows us to disable array spliting for arrays of arrays without
> regressing tests such as:
>
> ES31-CTS.functional.shaders.arrays_of_arrays.return.
> explicit.struct_3x1x3_fragment
> ---
>  src/compiler/nir/nir_lower_vars_to_ssa.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/compiler/nir/nir_lower_vars_to_ssa.c
> b/src/compiler/nir/nir_lower_vars_to_ssa.c
> index e5a12eb..31f7e7a 100644
> --- a/src/compiler/nir/nir_lower_vars_to_ssa.c
> +++ b/src/compiler/nir/nir_lower_vars_to_ssa.c
> @@ -441,7 +441,7 @@ static bool
>  lower_copies_to_load_store(struct deref_node *node,
>                             struct lower_variables_state *state)
>  {
> -   if (!node->copies)
> +   if (!node || !node->copies)
>

If we got a NULL node here, something is wrong.  I think this is just
papering over the issue.


>        return true;
>
>     struct set_entry *copy_entry;
> --
> 2.9.4
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170718/023da2de/attachment.html>