[Mesa-dev] [PATCH] configure.ac: rework wayland-protocols handling

Daniel Stone daniel at fooishbar.org
Fri Jul 21 12:28:15 UTC 2017


Hi Emil,

On 21 July 2017 at 13:02, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> At dist/distcheck time we need to ensure that all the files and their
> respective dependencies are handled.
>
> At the moment we'll bail out as the linux-dmabuf rules are guarded in a
> conditional. Move them outside of it and drop the sources from
> BUILT_SOURCES.

Why do we need to dist these files? We enforce that wayland (providing
wayland-scanner) and wayland-protocols (providing the XML) are present
at configure time, so disting them doesn't seem to provide any benefit
- they'll just be overwritten with the locally-generated variants. At
that point, we'll also have one copy in the source directory (from
dist), and another in the build directory (from local generation),
which seems like a recipe for disaster.

Cheers,
Daniel


More information about the mesa-dev mailing list