[Mesa-dev] [PATCH] configure.ac: rework wayland-protocols handling

[Emil Velikov]

On 21 July 2017 at 13:28, Daniel Stone <daniel at fooishbar.org> wrote:
> Hi Emil,
>
> On 21 July 2017 at 13:02, Emil Velikov <emil.l.velikov at gmail.com> wrote:
>> At dist/distcheck time we need to ensure that all the files and their
>> respective dependencies are handled.
>>
>> At the moment we'll bail out as the linux-dmabuf rules are guarded in a
>> conditional. Move them outside of it and drop the sources from
>> BUILT_SOURCES.
>
> Why do we need to dist these files? We enforce that wayland (providing
> wayland-scanner) and wayland-protocols (providing the XML) are present
> at configure time,
Good point Daniel. AFAICT the general principle in Mesa has been to
provide all the required sources so that extra tools are not needed.

We could lift the requirement in configure.ac, same way we do for
python/flex/bison. If the files are already there (aka we're using
release tarball) make the wayland bits a optdepend.

> so disting them doesn't seem to provide any benefit
> - they'll just be overwritten with the locally-generated variants. At
> that point, we'll also have one copy in the source directory (from
> dist), and another in the build directory (from local generation),
> which seems like a recipe for disaster.
>
The recipe for disaster part is a slight exaggeration. Plus we already
handle that case because people do in-tree builds :-\
It was addressed by my earlier suggestion to list the builddir include
before the srcdir one (which is in master).

-Emil