[Mesa-dev] [Mesa-stable] [PATCH] swr: use the correct variable for no undefined symbols

Emil Velikov emil.l.velikov at gmail.com
Fri Jul 21 15:45:18 UTC 2017


On 21 July 2017 at 16:29, Rowley, Timothy O <timothy.o.rowley at intel.com> wrote:
> Couple things about the patch: should PTHREAD_CFLAGS be added to COMMON_CXXFLAGS to avoid needing to modify the section for each architecture?  The KNL and SKX sections should have similar changes.
>
COMMON_CXXFLAGS is used by the loader as well and that one seems to be
fine. The libs part is already handled for each target so having some
symmetry won't be that bad ;-)

> I’ve tested that the scons binaries work on linux, and George tests them on windows.
>
It may be that something else is pulling pthreads, so it may be a
fluke. Please look at the output of ldd -r $foo as well.

I'll split and resent in a second.

Thanks
Emil


More information about the mesa-dev mailing list