[Mesa-dev] [PATCH 065/101] mesa: add KHR_no_error support to glDeleteBuffers()

Timothy Arceri tarceri at itsqueeze.com
Tue Jul 25 14:12:35 UTC 2017


56-65:

Reviewed-by: Timothy Arceri <tarceri at itsqueeze.com>

I've just sent a small series to remove some extra error paths from here 
that I noticed while reviewing this [1]

[1] https://patchwork.freedesktop.org/series/27863/

On 22/07/17 03:40, Samuel Pitoiset wrote:
> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
> ---
>   src/mapi/glapi/gen/gl_API.xml | 2 +-
>   src/mesa/main/bufferobj.c     | 8 ++++++++
>   src/mesa/main/bufferobj.h     | 3 +++
>   3 files changed, 12 insertions(+), 1 deletion(-)
> 
> diff --git a/src/mapi/glapi/gen/gl_API.xml b/src/mapi/glapi/gen/gl_API.xml
> index 60505e57b9..6f4d02d07d 100644
> --- a/src/mapi/glapi/gen/gl_API.xml
> +++ b/src/mapi/glapi/gen/gl_API.xml
> @@ -5062,7 +5062,7 @@
>           <glx ignore="true"/>
>       </function>
>   
> -    <function name="DeleteBuffers" es1="1.1" es2="2.0">
> +    <function name="DeleteBuffers" es1="1.1" es2="2.0" no_error="true">
>           <param name="n" type="GLsizei" counter="true"/>
>           <param name="buffer" type="const GLuint *" count="n"/>
>           <glx ignore="true"/>
> diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c
> index a3b871f0ad..c698cc9213 100644
> --- a/src/mesa/main/bufferobj.c
> +++ b/src/mesa/main/bufferobj.c
> @@ -1404,6 +1404,14 @@ delete_buffers(struct gl_context *ctx, GLsizei n, const GLuint *ids)
>   
>   
>   void GLAPIENTRY
> +_mesa_DeleteBuffers_no_error(GLsizei n, const GLuint *ids)
> +{
> +   GET_CURRENT_CONTEXT(ctx);
> +   delete_buffers(ctx, n, ids);
> +}
> +
> +
> +void GLAPIENTRY
>   _mesa_DeleteBuffers(GLsizei n, const GLuint *ids)
>   {
>      GET_CURRENT_CONTEXT(ctx);
> diff --git a/src/mesa/main/bufferobj.h b/src/mesa/main/bufferobj.h
> index 662ceba8a6..69e8549818 100644
> --- a/src/mesa/main/bufferobj.h
> +++ b/src/mesa/main/bufferobj.h
> @@ -162,6 +162,9 @@ void GLAPIENTRY
>   _mesa_BindBuffer(GLenum target, GLuint buffer);
>   
>   void GLAPIENTRY
> +_mesa_DeleteBuffers_no_error(GLsizei n, const GLuint * buffer);
> +
> +void GLAPIENTRY
>   _mesa_DeleteBuffers(GLsizei n, const GLuint * buffer);
>   
>   void GLAPIENTRY
> 


More information about the mesa-dev mailing list