[Mesa-dev] [PATCH] radeonsi: fix detection of DRAW_INDIRECT_MULTI on SI

Marek Olšák maraeo at gmail.com
Tue Jul 25 16:32:18 UTC 2017


Reviewed-by: Marek Olšák <marek.olsak at amd.com>

Marek

On Tue, Jul 25, 2017 at 4:51 PM, Nicolai Hähnle <nhaehnle at gmail.com> wrote:
> From: Nicolai Hähnle <nicolai.haehnle at amd.com>
>
> The firmware version numbers for SI were wrong. The new numbers are probably
> too conservative (we don't have a definitive answer by the firmware team),
> but DRAW_INDIRECT_MULTI has been confirmed to work with these versions on
> Tahiti (by Gustaw) and on Verde (by myself).
>
> While this is technically adding a feature, it's a feature we thought we had
> for a long time. The change is small enough and we're early enough in the 17.2
> release cycle that it should still go in.
>
> Reported-by: Gustaw Smolarczyk <wielkiegie at gmail.com>
> Cc: 17.2 <mesa-stable at lists.freedesktop.org>
> ---
>  src/gallium/drivers/radeonsi/si_pipe.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/gallium/drivers/radeonsi/si_pipe.c b/src/gallium/drivers/radeonsi/si_pipe.c
> index 0bc3002..2b0f9d3 100644
> --- a/src/gallium/drivers/radeonsi/si_pipe.c
> +++ b/src/gallium/drivers/radeonsi/si_pipe.c
> @@ -1002,8 +1002,8 @@ struct pipe_screen *radeonsi_screen_create(struct radeon_winsys *ws,
>                  sscreen->b.info.pfp_fw_version >= 211 &&
>                  sscreen->b.info.me_fw_version >= 173) ||
>                 (sscreen->b.chip_class == SI &&
> -                sscreen->b.info.pfp_fw_version >= 121 &&
> -                sscreen->b.info.me_fw_version >= 87);
> +                sscreen->b.info.pfp_fw_version >= 79 &&
> +                sscreen->b.info.me_fw_version >= 142);
>
>         sscreen->has_ds_bpermute = sscreen->b.chip_class >= VI;
>         sscreen->has_msaa_sample_loc_bug = (sscreen->b.family >= CHIP_POLARIS10 &&
> --
> 2.9.3
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list