[Mesa-dev] [PATCH 1/2] gallium/radeon: make S_FIXED function signed and move it to shared code

Kenneth Graunke kenneth at whitecape.org
Tue Jul 25 16:39:04 UTC 2017


On Tuesday, July 25, 2017 8:36:36 AM PDT Marek Olšák wrote:
> From: Marek Olšák <marek.olsak at amd.com>
> 
> This fixes a bug uncovered by:
>     2412c4c81ea0488df865817a0de91ec46e359b72
>     util: Make CLAMP turn NaN into MIN.
> ---
>  src/gallium/drivers/r600/r600_pipe.h          | 4 ----
>  src/gallium/drivers/radeon/r600_pipe_common.h | 5 +++++
>  src/gallium/drivers/radeonsi/si_state.c       | 5 -----
>  3 files changed, 5 insertions(+), 9 deletions(-)

You might want to use int32_t to match the copy in src/mesa/main/macros.h.
Longer term, we might want to move those to src/util/*.h, which would let
you drop your extra copy.

Either way,
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170725/97efad32/attachment.sig>


More information about the mesa-dev mailing list