[Mesa-dev] Initial support for EXT_external_objects v4

[Timothy Arceri]

On 27/07/17 04:53, Jason Ekstrand wrote:
> On July 26, 2017 8:48:18 AM Samuel Pitoiset <samuel.pitoiset at gmail.com> 
> wrote:
> 
>> Hi guys,
>>
>> I didn't review the radeonsi and radv patches, but I have sent comments
>> on other parts.
>>
>> More generally:
>>
>> - I wonder if some intermediate patches can break Mesa, would be nice to
>> avoid that (especially for bisecting) Can you double check?
>>
>> - I don't see any piglit tests... or did I miss them? :)
> 
> +1 on the need for tests.  I'll go even further and say that the obvious 
> minimal testing to exercise the extension is far from sufficient.  There 
> are a lot of complex ways in which two APIs can interact and we need to 
> ensure we get it right.  In particular, if we're going to claim that the 
> extension actually works properly we need:
> 
> 1. Tests which use more than just GL.  In particular, we need to test 
> sharing between GL and Vulcan.
> 
> 2. Test which exercise "complex" textures, i.e. textures with multiple 
> mip-levels, multiple array slices, 1D, 2D, 3D, etc.
> 
> 3. Tests which test different texture formats.
> 
> 4. Tests which test several different combinations of rendering, 
> clearing, glTexSubImage, etc. in one API and combinations of texturing, 
> glGetTexSubImage, etc. in the other API.
> 
> Preferably, a good set of combinations of the above.
> 
> Also, the Vulcan bits need to pass validation.  I shouldn't have to say 
> this but it's important and an easy thing to forget so I thought it 
> worth mentioning.

Sure I agree on the need for tests but this isn't a tiny amount of work. 
I don't necessarily think should block an initial implementation from 
landing.

Do you have a suggestion for how we should implement testing between 
Vulkan and OpenGL? Can we leverage the crucible framework at all? Or 
should we just create some basic Vulkan framework in piglit from 
scratch? I only picked up this work yesterday so I haven't put too much 
thought into it.


> 
> --Jason
> 
>> Thanks,
>> Samuel.
>>
>> On 07/26/2017 01:46 PM, Timothy Arceri wrote:
>>> Hi all,
>>>
>>> Andres is not around at the moment so as well are reviewing the
>>> remaining patches I've rebased and added all Marek's suggestions.
>>>
>>> I've also made a few minor changes (see commit messages) and
>>> reworked some of the patches to reduce code churn.
>>>
>>> I thought I'd send it out one last time to see if there was any
>>> more feedback otherwise I'll probably push later in the week.
>>>
>>> Thanks,
>>> Tim
>>>
>>> Series available at:
>>>    https://github.com/tarceri/Mesa.git (memobj2)
>>>
>>> _______________________________________________
>>> mesa-dev mailing list
>>> mesa-dev at lists.freedesktop.org
>>> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>>>
>> _______________________________________________
>> mesa-dev mailing list
>> mesa-dev at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> 
>