[Mesa-dev] [PATCH mesa 1/3] egl: use designated initaliser for _eglGlobal

[Emil Velikov]

On 30 July 2017 at 02:11, Eric Engestrom <eric at engestrom.ch> wrote:
> Turn comments into actual code, that the compiler can check for us :)
> (Speaking of, one of the comments had a typo. Challenge: find it)
>
Challenge accepted.

> Signed-off-by: Eric Engestrom <eric at engestrom.ch>
> ---
>  src/egl/main/eglglobals.c | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/src/egl/main/eglglobals.c b/src/egl/main/eglglobals.c
> index 9071226618..c506bd6a9d 100644
> --- a/src/egl/main/eglglobals.c
> +++ b/src/egl/main/eglglobals.c
> @@ -49,22 +49,22 @@ static mtx_t _eglGlobalMutex = _MTX_INITIALIZER_NP;
>
>  struct _egl_global _eglGlobal =
>  {
> -   &_eglGlobalMutex,       /* Mutex */
> -   NULL,                   /* DisplayList */
> -   2,                      /* NumAtExitCalls */
> -   {
> +   .Mutex = &_eglGlobalMutex,
> +   .DisplayList = NULL,
> +   .NumAtExitCalls = 2,
> +   .AtExitCalls = {
>        /* default AtExitCalls, called in reverse order */
>        _eglUnloadDrivers, /* always called last */
>        _eglFiniDisplay
>     },
>
> -   /* ClientOnlyExtensionString */
> +   .ClientOnlyExtensionString =
>     "EGL_EXT_client_extensions"
>     " EGL_EXT_platform_base"
>     " EGL_KHR_client_get_all_proc_addresses"
>     " EGL_KHR_debug",
>
> -   /* PlatformExtensionString */
> +   .PlatformExtensionString =
>  #ifdef HAVE_WAYLAND_PLATFORM
>     " EGL_EXT_platform_wayland"
>  #endif
> @@ -79,10 +79,10 @@ struct _egl_global _eglGlobal =
>  #endif
>     "",
>
> -   NULL, /* ClientExtensionsString */
> +   .ClientExtensionString = NULL,
Singular - "Extension"

For the series:
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>

-Emil