[Mesa-dev] [PATCH 7/8] mesa: remove redundant _ae_invalidate_state() call

[Samuel Pitoiset]

On 06/07/2017 01:14 PM, Timothy Arceri wrote:
> On 07/06/17 18:16, Samuel Pitoiset wrote:
>> How?
> _mesa_update_state() will call vbo_exec_invalidate_state() which calls 
> _ae_invalidate_state() because _NEW_ARRAY is passed to FLUSH_VERTICES()

Right, missed that.

Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>

> 
> 
>>
>> On 06/07/2017 08:02 AM, Timothy Arceri wrote:
>>> The FLUSH_VERTICES(ctx, _NEW_ARRAY) above this will already cause
>>> this to be called.
>>> ---
>>>   src/mesa/main/enable.c | 3 ---
>>>   1 file changed, 3 deletions(-)
>>>
>>> diff --git a/src/mesa/main/enable.c b/src/mesa/main/enable.c
>>> index ef278a3..00d672f 100644
>>> --- a/src/mesa/main/enable.c
>>> +++ b/src/mesa/main/enable.c
>>> @@ -30,21 +30,20 @@
>>>   #include "glheader.h"
>>>   #include "clip.h"
>>>   #include "context.h"
>>>   #include "debug_output.h"
>>>   #include "enable.h"
>>>   #include "errors.h"
>>>   #include "light.h"
>>>   #include "mtypes.h"
>>>   #include "enums.h"
>>> -#include "api_arrayelt.h"
>>>   #include "texstate.h"
>>>   #define CHECK_EXTENSION(EXTNAME, CAP)                    \
>>>      if (!ctx->Extensions.EXTNAME) {                    \
>>>         goto invalid_enum_error;                        \
>>>      }
>>> @@ -119,22 +118,20 @@ client_state(struct gl_context *ctx, GLenum 
>>> cap, GLboolean state)
>>>         default:
>>>            goto invalid_enum_error;
>>>      }
>>>      if (*var == state)
>>>         return;
>>>      FLUSH_VERTICES(ctx, _NEW_ARRAY);
>>> -   _ae_invalidate_state(ctx, _NEW_ARRAY);
>>> -
>>>      *var = state;
>>>      update_derived_primitive_restart_state(ctx);
>>>      if (state)
>>>         vao->_Enabled |= flag;
>>>      else
>>>         vao->_Enabled &= ~flag;
>>>      vao->NewArrays |= flag;
>>>