[Mesa-dev] [PATCH] i965: fix missing break

Jason Ekstrand jason at jlekstrand.net
Mon Jun 12 22:55:26 UTC 2017


Woah... Coverity was useful.

Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>

On Mon, Jun 12, 2017 at 3:49 PM, Ian Romanick <idr at freedesktop.org> wrote:

> On 06/12/2017 02:37 AM, Lionel Landwerlin wrote:
> > Pretty obvious missing break statement.
>
> Right... it looks like the code may have been structured differently at
> one time.
>
> Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>
>
> >
> > CID: 1412564
> > Fixes: 641405f797 "i965: Use the new tracking mechanism for HiZ"
> > Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
> > ---
> >  src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
> b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
> > index eda8a0afab5..bd816816a53 100644
> > --- a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
> > +++ b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
> > @@ -2300,6 +2300,7 @@ intel_miptree_finish_hiz_write(struct brw_context
> *brw,
> >           intel_miptree_set_aux_state(brw, mt, level, layer, 1,
> >                                       ISL_AUX_STATE_AUX_INVALID);
> >        }
> > +      break;
> >
> >     case ISL_AUX_STATE_PASS_THROUGH:
> >        if (written_with_hiz) {
> >
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170612/5cc9290f/attachment.html>


More information about the mesa-dev mailing list