[Mesa-dev] [PATCH 2/2] ac/gpu: drop duplicated code line.

[Ilia Mirkin]

On Mon, Jun 12, 2017 at 7:53 PM, Dave Airlie <airlied at gmail.com> wrote:
> From: Dave Airlie <airlied at redhat.com>
>
> has_hw_decode is assigned twice.
>
> Pointed out by coverity.
>
> Signed-off-by: Dave Airlie <airlied at redhat.com>
> ---
>  src/amd/common/ac_gpu_info.c     | 1 -
>  src/amd/vulkan/radv_cmd_buffer.c | 2 +-
>  2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/src/amd/common/ac_gpu_info.c b/src/amd/common/ac_gpu_info.c
> index dc3ae25..7d6f6e7 100644
> --- a/src/amd/common/ac_gpu_info.c
> +++ b/src/amd/common/ac_gpu_info.c
> @@ -249,7 +249,6 @@ bool ac_query_gpu_info(int fd, amdgpu_device_handle dev,
>         info->max_shader_clock = amdinfo->max_engine_clk / 1000;
>         info->max_se = amdinfo->num_shader_engines;
>         info->max_sh_per_se = amdinfo->num_shader_arrays_per_engine;
> -       info->has_hw_decode = uvd.available_rings != 0;
>         info->has_hw_decode =
>                 (uvd.available_rings != 0) || (vcn_dec.available_rings != 0);
>         info->uvd_fw_version =
> diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c
> index 9f36d98..320e653 100644
> --- a/src/amd/vulkan/radv_cmd_buffer.c
> +++ b/src/amd/vulkan/radv_cmd_buffer.c
> @@ -3173,7 +3173,7 @@ static void radv_handle_dcc_image_transition(struct radv_cmd_buffer *cmd_buffer,
>                 radv_initialize_dcc(cmd_buffer, image, 0x20202020u);
>         } else if (radv_layout_can_fast_clear(image, src_layout, src_queue_mask) &&
>                    !radv_layout_can_fast_clear(image, dst_layout, dst_queue_mask)) {
> -               radv_fast_clear_flush_image_inplace(cmd_buffer, image, range);
> +         //            radv_fast_clear_flush_image_inplace(cmd_buffer, image, range);

seems unrelated...

>         }
>  }
>
> --
> 2.9.4
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev