[Mesa-dev] [PATCH 2/2] ac/gpu: drop duplicated code line.

Marek Olšák maraeo at gmail.com
Tue Jun 13 15:09:34 UTC 2017


On Tue, Jun 13, 2017 at 2:00 AM, Bas Nieuwenhuizen
<bas at basnieuwenhuizen.nl> wrote:
> With the unrelated line removed,

Same here.

Reviewed-by: Marek Olšák <marek.olsak at amd.com>

Marek


>
> Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
>
> On Tue, Jun 13, 2017 at 1:54 AM, Dave Airlie <airlied at gmail.com> wrote:
>> On 13 June 2017 at 09:53, Dave Airlie <airlied at gmail.com> wrote:
>>> From: Dave Airlie <airlied at redhat.com>
>>>
>>> has_hw_decode is assigned twice.
>>>
>>> Pointed out by coverity.
>>>
>>> Signed-off-by: Dave Airlie <airlied at redhat.com>
>>> ---
>>>  src/amd/common/ac_gpu_info.c     | 1 -
>>>  src/amd/vulkan/radv_cmd_buffer.c | 2 +-
>>>  2 files changed, 1 insertion(+), 2 deletions(-)
>>>
>>> diff --git a/src/amd/common/ac_gpu_info.c b/src/amd/common/ac_gpu_info.c
>>> index dc3ae25..7d6f6e7 100644
>>> --- a/src/amd/common/ac_gpu_info.c
>>> +++ b/src/amd/common/ac_gpu_info.c
>>> @@ -249,7 +249,6 @@ bool ac_query_gpu_info(int fd, amdgpu_device_handle dev,
>>>         info->max_shader_clock = amdinfo->max_engine_clk / 1000;
>>>         info->max_se = amdinfo->num_shader_engines;
>>>         info->max_sh_per_se = amdinfo->num_shader_arrays_per_engine;
>>> -       info->has_hw_decode = uvd.available_rings != 0;
>>>         info->has_hw_decode =
>>>                 (uvd.available_rings != 0) || (vcn_dec.available_rings != 0);
>>>         info->uvd_fw_version =
>>
>>
>> Ooops ignore hunk below.
>>
>> Dave.
>> _______________________________________________
>> mesa-dev mailing list
>> mesa-dev at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list