[Mesa-dev] [PATCH] mesa: fix 'make check' by moving bindless functions at the right place

Ian Romanick idr at freedesktop.org
Wed Jun 14 22:57:37 UTC 2017


On 06/14/2017 09:30 AM, Aaron Watry wrote:
> Looks like Mark beat me to reporting this one (was still bisecting
> when this patch was sent).
> 
> Tested-by: Aaron Watry <awatry at gmail.com>

If dispatch_sanity breaks, it's almost always the most recent commit in
src/mapi/glapi/gen.  That may save you some time bisecting when this
happens again. :)

> On Wed, Jun 14, 2017 at 11:08 AM, Samuel Pitoiset
> <samuel.pitoiset at gmail.com> wrote:
>> Fixes: 5f249b9f05e ("mapi: add GL_ARB_bindless_texture entry points")
>> Reported-by: Mark Janes <mark.a.janes at intel.com>
>> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
>> ---
>>  src/mesa/main/tests/dispatch_sanity.cpp | 36 ++++++++++++++++-----------------
>>  1 file changed, 18 insertions(+), 18 deletions(-)
>>
>> diff --git a/src/mesa/main/tests/dispatch_sanity.cpp b/src/mesa/main/tests/dispatch_sanity.cpp
>> index 47d0aa63bf4..724c22ee9b3 100644
>> --- a/src/mesa/main/tests/dispatch_sanity.cpp
>> +++ b/src/mesa/main/tests/dispatch_sanity.cpp
>> @@ -965,6 +965,24 @@ const struct function common_desktop_functions_possible[] = {
>>     { "glBufferPageCommitmentARB", 43, -1 },
>>     { "glNamedBufferPageCommitmentARB", 43, -1 },
>>
>> +   /* GL_ARB_bindless_texture */
>> +   { "glGetTextureHandleARB", 40, -1 },
>> +   { "glGetTextureSamplerHandleARB", 40, -1 },
>> +   { "glMakeTextureHandleResidentARB", 40, -1 },
>> +   { "glMakeTextureHandleNonResidentARB", 40, -1 },
>> +   { "glIsTextureHandleResidentARB", 40, -1 },
>> +   { "glGetImageHandleARB", 40, -1 },
>> +   { "glMakeImageHandleResidentARB", 40, -1 },
>> +   { "glMakeImageHandleNonResidentARB", 40, -1 },
>> +   { "glIsImageHandleResidentARB", 40, -1 },
>> +   { "glUniformHandleui64ARB", 40, -1 },
>> +   { "glUniformHandleui64vARB", 40, -1 },
>> +   { "glProgramUniformHandleui64ARB", 40, -1 },
>> +   { "glProgramUniformHandleui64vARB", 40, -1 },
>> +   { "glVertexAttribL1ui64ARB", 40, -1 },
>> +   { "glVertexAttribL1ui64vARB", 40, -1 },
>> +   { "glGetVertexAttribLui64vARB", 40, -1 },
>> +
>>     { NULL, 0, -1 }
>>  };
>>
>> @@ -2374,24 +2392,6 @@ const struct function gles2_functions_possible[] = {
>>     /* GL_KHR_blend_equation_advanced */
>>     { "glBlendBarrierKHR", 20, -1 },
>>
>> -   /* GL_ARB_bindless_texture */
>> -   { "glGetTextureHandleARB", 40, -1 },
>> -   { "glGetTextureSamplerHandleARB", 40, -1 },
>> -   { "glMakeTextureHandleResidentARB", 40, -1 },
>> -   { "glMakeTextureHandleNonResidentARB", 40, -1 },
>> -   { "glIsTextureHandleResidentARB", 40, -1 },
>> -   { "glGetImageHandleARB", 40, -1 },
>> -   { "glMakeImageHandleResidentARB", 40, -1 },
>> -   { "glMakeImageHandleNonResidentARB", 40, -1 },
>> -   { "glIsImageHandleResidentARB", 40, -1 },
>> -   { "glUniformHandleui64ARB", 40, -1 },
>> -   { "glUniformHandleui64vARB", 40, -1 },
>> -   { "glProgramUniformHandleui64ARB", 40, -1 },
>> -   { "glProgramUniformHandleui64vARB", 40, -1 },
>> -   { "glVertexAttribL1ui64ARB", 40, -1 },
>> -   { "glVertexAttribL1ui64vARB", 40, -1 },
>> -   { "glGetVertexAttribLui64vARB", 40, -1 },
>> -
>>     { NULL, 0, -1 }
>>  };
>>
>> --
>> 2.13.1
>>
>> _______________________________________________
>> mesa-dev mailing list
>> mesa-dev at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> 



More information about the mesa-dev mailing list