[Mesa-dev] [PATCH mesa 2/2] egl/display: make platform detection thread-safe

[Eric Engestrom]

On Thursday, 2017-06-15 14:24:55 +0300, Grazvydas Ignotas wrote:
> On Thu, Jun 1, 2017 at 2:15 PM, Eric Engestrom
> <eric.engestrom at imgtec.com> wrote:
> > If the detections methods ever become able to return different results
> > for different threads, the if chain might make threads go back and forth
> > between invalid and valid platforms.
> > Solve this by doing the detection in a local var and only overwriting
> > the global one at the end, if no other thread has updated it since.
> >
> > This means the platform detected in the thread might not be the platform
> > returned by the function, but this is a different issue that will need
> > to be discussed when this becomes possible.
> >
> > Reported-by: Grazvydas Ignotas <notasas at gmail.com>
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100877
> 
> > Signed-off-by: Eric Engestrom <eric.engestrom at imgtec.com>
> 
> It seems this has stalled.

Yes indeed, I kinda forgot about this patchset.
Thanks for the reminder :)

> With the commit message updated (as
> detailed in my previous mail, bad things can happen even with matching
> thread results), and optionally putting everything in a if block to
> avoid expensive cmpxchg on non-first run, this is
> 
> Reviewed-by: Grazvydas Ignotas <notasas at gmail.com>
> 
> I think you can add Emil's Acked-by too.

I'll do all that tonight.

Cheers,
  Eric

/me notes that he should look at his other forgotten patches.