[Mesa-dev] [PATCH] radeonsi: remove useless check in si_set_clip_state()

Marek Olšák maraeo at gmail.com
Thu Jun 15 14:59:38 UTC 2017


I think it's safer to keep this, considering that the call is quite expensive.

Marek

On Thu, Jun 15, 2017 at 11:47 AM, Samuel Pitoiset
<samuel.pitoiset at gmail.com> wrote:
> st/mesa already takes care of this.
>
> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
> ---
>  src/gallium/drivers/radeonsi/si_state.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/src/gallium/drivers/radeonsi/si_state.c b/src/gallium/drivers/radeonsi/si_state.c
> index 1cd1f9190e0..ac9358c6b3b 100644
> --- a/src/gallium/drivers/radeonsi/si_state.c
> +++ b/src/gallium/drivers/radeonsi/si_state.c
> @@ -659,9 +659,6 @@ static void si_set_clip_state(struct pipe_context *ctx,
>         struct si_context *sctx = (struct si_context *)ctx;
>         struct pipe_constant_buffer cb;
>
> -       if (memcmp(&sctx->clip_state.state, state, sizeof(*state)) == 0)
> -               return;
> -
>         sctx->clip_state.state = *state;
>         si_mark_atom_dirty(sctx, &sctx->clip_state.atom);
>
> --
> 2.13.1
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list