[Mesa-dev] [PATCH] i965: don't call dup() twice when calling eglDupNativeFenceFDANDROID.
Tapani Pälli
tapani.palli at intel.com
Fri Jun 16 07:30:54 UTC 2017
Oops sorry, forget about this one. This does not work ok :/ Need to take
a closer look why.
On 06/16/2017 10:21 AM, Tapani Pälli wrote:
> From: Randy Xu <randy.xu at intel.com>
>
> This was causing crashes in Vulkan and GLES stress testing.
>
> Currently, both libEGL and the DRI module call dup when the function
> is called. Remove the former since it's ultimately a driver decision
> how to manage the file descriptor.
>
> v2: remove dup from the EGL layer (Emil Velikov)
>
> Fixes: 0201f01dc4e ("egl: add EGL_ANDROID_native_fence_sync")
> Signed-off-by: Randy Xu <randy.xu at intel.com>
> ---
> src/egl/drivers/dri2/egl_dri2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/drivers/dri2/egl_dri2.c
> index 020a0bc..0caccd4 100644
> --- a/src/egl/drivers/dri2/egl_dri2.c
> +++ b/src/egl/drivers/dri2/egl_dri2.c
> @@ -2885,7 +2885,7 @@ dri2_dup_native_fence_fd(_EGLDriver *drv, _EGLDisplay *dpy, _EGLSync *sync)
> return EGL_NO_NATIVE_FENCE_FD_ANDROID;
> }
>
> - return dup(sync->SyncFd);
> + return sync->SyncFd;
> }
>
> static EGLint
>
More information about the mesa-dev
mailing list