[Mesa-dev] [PATCH mesa v2 1/2] egl/display: only detect the platform once

Eric Engestrom eric.engestrom at imgtec.com
Fri Jun 16 11:17:07 UTC 2017


On Friday, 2017-06-16 12:10:55 +0300, Grazvydas Ignotas wrote:
> On Fri, Jun 16, 2017 at 1:53 AM, Eric Engestrom <eric at engestrom.ch> wrote:
> > My refactor missed the fact that `native_platform` is static.
> > Add the proper guard around the detection code, as it might not be
> > necessary, and only print the debug message when a detection was
> > actually performed.
> >
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101252
> > Fixes: 7adb9b094894a512c019 ("egl/display: remove unnecessary code and
> >                               make it easier to read")
> > Signed-off-by: Eric Engestrom <eric at engestrom.ch>
> > Reviewed-by: Grazvydas Ignotas <notasas at gmail.com>
> > Ack-by: Emil Velikov <emil.l.velikov at gmail.com>
> 
> nit1: usually it's "Acked-by", but there are a few "Ack-by" in git
> history too (2255 vs 3).
> 
[...]
> 
> nit2: you can make it const. Either way, my r-b still stands.

Fixed both and pushed, thanks and sorry it took so long :)

Cheers,
  Eric


More information about the mesa-dev mailing list