[Mesa-dev] [PATCH 2/2] st/vdpau: fold vdpau_interop.h and vdpau_dmabuf.h

[Ilia Mirkin]

On Fri, Jun 16, 2017 at 8:15 AM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> On 16 June 2017 at 13:11, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
>> On Jun 16, 2017 8:09 AM, "Emil Velikov" <emil.l.velikov at gmail.com> wrote:
>>
>> On 16 June 2017 at 13:00, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
>>> On Fri, Jun 16, 2017 at 7:51 AM, Emil Velikov <emil.l.velikov at gmail.com>
>>> wrote:
>>>> On 25 April 2017 at 15:32, Emil Velikov <emil.l.velikov at gmail.com> wrote:
>>>>> On 25 April 2017 at 15:06, Christian König <deathsimple at vodafone.de>
>>>>> wrote:
>>>>>> Am 25.04.2017 um 15:17 schrieb Ilia Mirkin:
>>>>>>>
>>>>>>> [SNIP]
>>>>>>> Is there a patch I should test?
>>>>>>
>>>>>>
>>>>>> Patch is attached, but only compile tested.
>>>>>>
>>>>>> Basically if OpenGL/VDPAU interop worked before with Kodi/MPV it should
>>>>>> still keep working.
>>>>>>
>>>>> I think we can make nouveau_drm_screen_create private and drop it from
>>>>> dri.sym, vdpau.sym + dri-vdpau.dyn
>>>>> Not 100% sure though ... we might need it for Xinerama.
>>>>>
>>>> Ilia, did you had the chance to test the patch with or w/o the extra
>>>> bits suggested?
>>>
>>> This was not on my radar for testing. What needs testing exactly?
>>
>>> Apply the patch and see if OpenGL/VDPAU in Kodi/MPV still works with
>>> nouveau.
>>> Do try it with DRI2 and DRI3. My extra suggestions can be sorted at a
>>> later stage.
>>>
>>> https://patchwork.freedesktop.org/patch/152674/
>>>
>>
>> Opengl + vdpau never work in mpv/Kodi. Problem solved?
>>
> Hmm surely GL VDPAU interop worked somewhere/somehow? Maarten do you
> recall how/where you tested it as you added the nouveau bits?
>
> If nothing comes to mind, we might as well merge the patch. I have a
> crazy idea that the patch alongside few extra actually might get it
> working ;-) But that for later.

GL/VDPAU interop works. Just not the way that mpv/kodi use it (at
least today). I'm not inclined to particularly worry about it... this
can all be reverted later if necessary.

  -ilia