[Mesa-dev] [PATCH] intel: compiler/i965: fix is_broxton checks

[Kenneth Graunke]

On Tuesday, June 20, 2017 10:05:26 AM PDT Ian Romanick wrote:
> On 06/20/2017 05:23 AM, Lionel Landwerlin wrote:
> > In 5f2fe9302c is_geminilake was introduced for the differenciate
> > broxton from geminilake. Unfortunately I failed as verifying that
> > is_broxton is throughout the code base to mean Gen9lp.
> 
> It looks like this replaces every instances of devinfo->is_broxton.  Why
> not just s/devinfo->is_broxton/devinfo->gen9lp/g and change the way the
> field is set?  This is effectively what the change to brw_context.c does
> to brw_context::is_broxton.

I've also wondered about having an is_atom bit, so you could just do
if (gen == 9 && is_atom) or something for BYT/BSW/BXT/GLK checks.  *shrug*
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170620/63fb2463/attachment-0001.sig>