[Mesa-dev] [PATCH v3 1/3] dri: Add UYVY as available format

[Kristian H. Kristensen]

Johnson Lin <johnson.lin at intel.com> writes:

> UYVY is diffrent with YUYV in byte order.
> YUYV is already declared in dri_interface.h,
> this CL add the difinitions for UYVY.
> Drivers can add UYVY as supported format

This series looks good now. There are a few stylistic nits in the
comment formatting below, but with that fixed, this is

Reviewed-by: Kristian H. Kristensen <hoegsberg at google.com>

> ---
>  include/GL/internal/dri_interface.h | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/include/GL/internal/dri_interface.h b/include/GL/internal/dri_interface.h
> index fc2d4bbe22ef..6992da16d5f8 100644
> --- a/include/GL/internal/dri_interface.h
> +++ b/include/GL/internal/dri_interface.h
> @@ -1211,6 +1211,7 @@ struct __DRIdri2ExtensionRec {
>  #define __DRI_IMAGE_FOURCC_NV12		0x3231564e
>  #define __DRI_IMAGE_FOURCC_NV16		0x3631564e
>  #define __DRI_IMAGE_FOURCC_YUYV		0x56595559
> +#define __DRI_IMAGE_FOURCC_UYVY		0x59565955
>  
>  #define __DRI_IMAGE_FOURCC_YVU410	0x39555659
>  #define __DRI_IMAGE_FOURCC_YVU411	0x31315659
> @@ -1224,7 +1225,7 @@ struct __DRIdri2ExtensionRec {
>   * RGB and RGBA are may be usable directly as images but its still
>   * recommended to call fromPlanar with plane == 0.
>   *
> - * Y_U_V, Y_UV and Y_XUXV all requires call to fromPlanar to create
> + * Y_U_V, Y_UV,Y_XUXV and Y_UXVX all requires call to fromPlanar to create
                  ^
Space after the comma here.

>   * usable sub-images, sampling from images return raw YUV data and
>   * color conversion needs to be done in the shader.
>   *
> @@ -1236,6 +1237,7 @@ struct __DRIdri2ExtensionRec {
>  #define __DRI_IMAGE_COMPONENTS_Y_U_V	0x3003
>  #define __DRI_IMAGE_COMPONENTS_Y_UV	0x3004
>  #define __DRI_IMAGE_COMPONENTS_Y_XUXV	0x3005
> +#define __DRI_IMAGE_COMPONENTS_Y_UXVX	0x3008
>  #define __DRI_IMAGE_COMPONENTS_R	0x3006
>  #define __DRI_IMAGE_COMPONENTS_RG	0x3007
>  
> -- 
> 1.9.1
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev