[Mesa-dev] [PATCH 01/11] util: Remove u_math from u_vector

[Lucas Stach]

Am Freitag, den 16.06.2017, 18:14 +0100 schrieb Daniel Stone:
> u_vector.h doesn't actually use anything from u_math, but it does mean
> everyone has to pull in src/gallium/auxiliary/util includes.
> 
> Just remove it, adding a <string.h> include to u_vector.c to cover
> memcpy.

This patch seems to cause:

src/util/u_vector.c: In function 'u_vector_init':
src/util/u_vector.c:30:4: error: implicit declaration of function 'util_is_power_of_two' [-Werror=implicit-function-declaration]

Regards,
Lucas

> Signed-off-by: Daniel Stone <daniels at collabora.com>
> ---
>  src/util/u_vector.c | 2 ++
>  src/util/u_vector.h | 1 -
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/util/u_vector.c b/src/util/u_vector.c
> index 37c4245ebe..afe0924e4c 100644
> --- a/src/util/u_vector.c
> +++ b/src/util/u_vector.c
> @@ -20,6 +20,8 @@
>   * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
>   * IN THE SOFTWARE.
>   */
> +
> +#include <string.h>
>  #include "util/u_vector.h"
>  
>  int
> diff --git a/src/util/u_vector.h b/src/util/u_vector.h
> index c0e199cfa5..cd8a95dcbe 100644
> --- a/src/util/u_vector.h
> +++ b/src/util/u_vector.h
> @@ -31,7 +31,6 @@
>  
>  #include <stdint.h>
>  #include <stdlib.h>
> -#include "util/u_math.h"
>  #include "util/macros.h"
>  
>  /* TODO - move to u_math.h - name it better etc */