[Mesa-dev] [PATCH 01/11] util: Remove u_math from u_vector

Daniel Stone daniel at fooishbar.org
Thu Jun 22 15:23:24 UTC 2017


Hey Lucas,

On 22 June 2017 at 16:03, Lucas Stach <l.stach at pengutronix.de> wrote:
> Am Freitag, den 16.06.2017, 18:14 +0100 schrieb Daniel Stone:
>> u_vector.h doesn't actually use anything from u_math, but it does mean
>> everyone has to pull in src/gallium/auxiliary/util includes.
>>
>> Just remove it, adding a <string.h> include to u_vector.c to cover
>> memcpy.
>
> This patch seems to cause:
>
> src/util/u_vector.c: In function 'u_vector_init':
> src/util/u_vector.c:30:4: error: implicit declaration of function 'util_is_power_of_two' [-Werror=implicit-function-declaration]

CI caught that as well; I'm carrying an addition of a u_math.h include
inside u_vector.c (not u_vector.h) which fixes it.

Cheers,
Daniel


More information about the mesa-dev mailing list