[Mesa-dev] [PATCH 01/18] nir/spirv: Move a "}"

[Jason Ekstrand]

On Thu, Jun 29, 2017 at 2:26 PM, Lionel Landwerlin <
lionel.g.landwerlin at intel.com> wrote:

> How did this even compile?
>

Because aparently C lets you put switch cases anywhere.


> Should we cc stable?
>

I debated that.  I don't think it's needed as this isn't actually a
functional change.


> Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
>

Thanks!


> On 29/06/17 18:33, Jason Ekstrand wrote:
>
>> It's closing a "{" at the begining of a switch case.
>> ---
>>   src/compiler/spirv/vtn_variables.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/compiler/spirv/vtn_variables.c
>> b/src/compiler/spirv/vtn_variables.c
>> index 974adb5..31d1d76 100644
>> --- a/src/compiler/spirv/vtn_variables.c
>> +++ b/src/compiler/spirv/vtn_variables.c
>> @@ -1490,10 +1490,10 @@ vtn_handle_variables(struct vtn_builder *b, SpvOp
>> opcode,
>>             */
>>            vtn_foreach_decoration(b, interface_type->val,
>> var_decoration_cb, var);
>>            break;
>> +      }
>>           case vtn_variable_mode_param:
>>            unreachable("Not created through OpVariable");
>> -      }
>>           case vtn_variable_mode_ubo:
>>         case vtn_variable_mode_ssbo:
>>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170629/a222cf0f/attachment.html>