[Mesa-dev] [PATCH v3 1/5] etnaviv: Add unreachable statement to etna_amode to fix compilation warnings

[Emil Velikov]

On 29 June 2017 at 16:40, Robert Foss <robert.foss at collabora.com> wrote:
> On Thu, 2017-06-29 at 15:29 +0100, Emil Velikov wrote:
>> On 28 June 2017 at 22:52, Robert Foss <robert.foss at collabora.com>
>> wrote:
>> > From: Tomeu Vizoso <tomeu.vizoso at collabora.com>
>> >
>> > Signed-off-by: Robert Foss <robert.foss at collabora.com>
>> > Reviewed-by: Tapani Pälli <tapani.palli at intel.com>
>>
>> Fwiw
>> Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
>>
>> Any additional changes (change the int:4 to enum foo:4 in the
>> headers,
>> propagate that through the codebase, drop the default case) can be
>> done at a later stage.
>
> You mean something like this?
> -   unsigned Swizzle : 2;  /* TGSI_SWIZZLE_ */
> +   enum_swizzle Swizzle : 2;  /* TGSI_SWIZZLE_ */
>
Yes, that's the first step. Next checks that we consistently use
enum_swizzle instead of unsigned throughout the codebase. And finally
default cases like the one in the patch are dropped.

Pretty much none of this is required for the patches to land. Just
some janitorial tasks which came up in earlier thread.
/me proceeds to double-check the series and push.

-Emil