[Mesa-dev] [PATCH v3 1/5] etnaviv: Add unreachable statement to etna_amode to fix compilation warnings

[Christian Gmeiner]

2017-06-30 9:39 GMT+02:00 Emil Velikov <emil.l.velikov at gmail.com>:
> On 29 June 2017 at 16:40, Robert Foss <robert.foss at collabora.com> wrote:
>> On Thu, 2017-06-29 at 15:29 +0100, Emil Velikov wrote:
>>> On 28 June 2017 at 22:52, Robert Foss <robert.foss at collabora.com>
>>> wrote:
>>> > From: Tomeu Vizoso <tomeu.vizoso at collabora.com>
>>> >
>>> > Signed-off-by: Robert Foss <robert.foss at collabora.com>
>>> > Reviewed-by: Tapani Pälli <tapani.palli at intel.com>
>>>
>>> Fwiw
>>> Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
>>>
>>> Any additional changes (change the int:4 to enum foo:4 in the
>>> headers,
>>> propagate that through the codebase, drop the default case) can be
>>> done at a later stage.
>>
>> You mean something like this?
>> -   unsigned Swizzle : 2;  /* TGSI_SWIZZLE_ */
>> +   enum_swizzle Swizzle : 2;  /* TGSI_SWIZZLE_ */
>>
> Yes, that's the first step. Next checks that we consistently use
> enum_swizzle instead of unsigned throughout the codebase. And finally
> default cases like the one in the patch are dropped.
>
> Pretty much none of this is required for the patches to land. Just
> some janitorial tasks which came up in earlier thread.
> /me proceeds to double-check the series and push.
>

Reviewed-by: Christian Gmeiner <christian.gmeiner at gmail.com>

Lets get the current patch(es) pushed and we can have a look at possible
refactoring/cleanup tasks later on. Maybe I will give a quick spin on my own.

greets
--
Christian Gmeiner, MSc

https://www.youtube.com/user/AloryOFFICIAL
https://soundcloud.com/christian-gmeiner