[Mesa-dev] [Bug 100073] Shader Disk Cache 32/64 bit detection has a flaw. Missed existence of x32 ABI

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=100073

--- Comment #2 from Darren Salt <bugspam at moreofthesa.me.uk> ---
This code is intended to be generic; it SHOULD work for other pairs such as
armel and aarch64 (though breakage will happen should you have more than one
32-bit ARM ABI in use on one system). As such, as it's written, it should not
be testing __i386__, __x86_64__ or similar macros, but it does need to test
__ILP32__.

(Aside: x32 code is 64-bit.)

Without optimisation, yes, the testing is effectively at run-time; however, the
values are constant. So in that sense, it's a small amount of bloat and
unreachable code.

FWIW, my implementation (which uses the ABI name from the architecture triplet)
is here:
  https://patchwork.freedesktop.org/patch/141891/

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170306/0bc964af/attachment-0001.html>