[Mesa-dev] [PATCH] Convert sed(1) syntax to be compatible with FreeBSD and OpenBSD

[Eric Engestrom]

On Monday, 2017-03-13 11:56:45 +0000, Jan Beich wrote:
> Eric Engestrom <eric.engestrom at imgtec.com> writes:
> 
> >> +    echo " `$1`" | sed -E \
> >> +        -e 's/[[[:space:]]]+-m[[^[:space:]]]*//g' \
> >
> > These only work for me if I remove the outermost `[]` on each line,
> > leaving one pair around `:space:` and one for the set.
> > The above line, for instance, becomes:
> >   -e 's/[[:space:]]+-m[^[:space:]]*//g' \
> >
> > Are those outer brackets necessary on *BSD? I don't have one available
> > to test this myself.
> 
> configure.ac is written in autoconf, so some characters have to be quoted.
> `[' and `]' are quote markers, so one layer is stripped.

My bad, I simply copy-pasted the sed commands into a terminal to test
them...

> Do you want me to quote the whole function (including whitespace)
> instead?
> 
> https://www.gnu.org/software/autoconf/manual/autoconf.html#M4-Quotation

No, your change is right, my r-b apply as is, and I'll do an actual
am+test after lunch and add my t-b.

Do you want me to push your patch?

Cheers,
  Eric