[Mesa-dev] [PATCH] Convert sed(1) syntax to be compatible with FreeBSD and OpenBSD

Jan Beich jbeich at freebsd.org
Mon Mar 13 13:26:30 UTC 2017


Eric Engestrom <eric.engestrom at imgtec.com> writes:

> On Monday, 2017-03-13 11:56:45 +0000, Jan Beich wrote:
>
>> Eric Engestrom <eric.engestrom at imgtec.com> writes:
>> 
>> >> +    echo " `$1`" | sed -E \
>> >> +        -e 's/[[[:space:]]]+-m[[^[:space:]]]*//g' \
[...]
>> Do you want me to quote the whole function (including whitespace)
>> instead?
>> 
>> https://www.gnu.org/software/autoconf/manual/autoconf.html#M4-Quotation
>
> No, your change is right, my r-b apply as is, and I'll do an actual
> am+test after lunch and add my t-b.

Thanks. I've only tested the patch against Mesa 17.0.1 downstream:
- build on FreeBSD 10.3, 11.0, 12.0
- runtime via glxgears (and a few games) + i965 + Skylake GT2

>
> Do you want me to push your patch?

Yes, please.


More information about the mesa-dev mailing list