[Mesa-dev] [PATCH] anv: add the main include directory back

[Grazvydas Ignotas]

On Sun, Mar 19, 2017 at 11:21 PM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> On 19 March 2017 at 19:30, Jason Ekstrand <jason at jlekstrand.net> wrote:
>> On March 19, 2017 9:33:02 AM Grazvydas Ignotas <notasas at gmail.com> wrote:
>>
>>> On Sun, Mar 19, 2017 at 3:03 PM, Emil Velikov <emil.l.velikov at gmail.com>
>>> wrote:
>>>>
>>>> Hi Grazvydas,
>>>>
>>>> On 17 March 2017 at 22:05, Grazvydas Ignotas <notasas at gmail.com> wrote:
>>>>>
>>>>> Fixes build without vulkan.h installed in system header locations:
>>>>>   CC       vulkan/vulkan_libvulkan_intel_la-anv_gem.lo
>>>>> In file included from vulkan/anv_private.h:66:0,
>>>>>                  from vulkan/anv_gem.c:31:
>>>>> /opt/xorg/include/vulkan/vulkan_intel.h:27:20: fatal error: vulkan.h:
>>>>> No such file or directory
>>>>>
>>>> Not sure the above makes sense I'm afraid. VULKAN_CPPFLAGS already
>>>> includes AM_CPPFLAGS which has the include.
>>>>
>>>> I've even hacked up my system [sudo mv
>>>> /usr/include/vulkan/vulkan.h{,1} and things build fine w/o your patch.
>>>
>>>
>>> Maybe you forgot --with-vulkan-drivers=intel for this test?
>>>
>>> Anyway the problem is without my patch my includes look like this:
>>> ...  -I/opt/xorg/include -I/opt/xorg/include/libdrm -I../../include ...
>>>
> Grazvydas, c'mon man seriously ? If your compiler does not fall-back
> and look into the other -I locations for the said header it's just
> broken ;-(

I guess you've misunderstood the problem, there is nothing to fall
back to: -I../../include/vulkan/ is not specified at all. The reason
it works in the "good" case is because both vulkan_intel.h and
vulkan.h are in the same directory: ../../include/vulkan/ (same if you
have those files in /usr/include/vulkan/ ).

Gražvydas