[Mesa-dev] [PATCH] anv: add the main include directory back

[Tapani Pälli]

On 03/19/2017 11:21 PM, Emil Velikov wrote:
> On 19 March 2017 at 19:30, Jason Ekstrand <jason at jlekstrand.net> wrote:
>> On March 19, 2017 9:33:02 AM Grazvydas Ignotas <notasas at gmail.com> wrote:
>>
>>> On Sun, Mar 19, 2017 at 3:03 PM, Emil Velikov <emil.l.velikov at gmail.com>
>>> wrote:
>>>>
>>>> Hi Grazvydas,
>>>>
>>>> On 17 March 2017 at 22:05, Grazvydas Ignotas <notasas at gmail.com> wrote:
>>>>>
>>>>> Fixes build without vulkan.h installed in system header locations:
>>>>>   CC       vulkan/vulkan_libvulkan_intel_la-anv_gem.lo
>>>>> In file included from vulkan/anv_private.h:66:0,
>>>>>                  from vulkan/anv_gem.c:31:
>>>>> /opt/xorg/include/vulkan/vulkan_intel.h:27:20: fatal error: vulkan.h:
>>>>> No such file or directory
>>>>>
>>>> Not sure the above makes sense I'm afraid. VULKAN_CPPFLAGS already
>>>> includes AM_CPPFLAGS which has the include.
>>>>
>>>> I've even hacked up my system [sudo mv
>>>> /usr/include/vulkan/vulkan.h{,1} and things build fine w/o your patch.
>>>
>>>
>>> Maybe you forgot --with-vulkan-drivers=intel for this test?
>>>
>>> Anyway the problem is without my patch my includes look like this:
>>> ...  -I/opt/xorg/include -I/opt/xorg/include/libdrm -I../../include ...
>>>
> Grazvydas, c'mon man seriously ? If your compiler does not fall-back
> and look into the other -I locations for the said header it's just
> broken ;-(
> Or maybe it does but the ifndef guard in vulkan.h kicks in - quick
> check is to grep your whole system for "VULKAN_H_"
>
>>> With that, it's picking the earlier installed
>>> /opt/xorg/include/vulkan/vulkan_intel.h instead of
>>> ../../include/vulkan/vulkan_intel.h , and that one has:
>>
>>
>> We should probably make sure that mesa includes come before includes from
>> other random projects.  That said, why is xorg packaging Vulkan headers?
>> And why is *anyone* packaging vulkan_intel.h???
>>
> Having local vs local vulkan.h should not lead to any difference
> really. That aside - people tend to have "local" xorg (and friends)
> builds in /opt/xorg rather than overwriting the files provided by
> their distribution.
> Which is the saner option, even if [cough] some devs intentionally ignore it ;-)
>
> That aside - can we get the Intel extension ratified and included in
> upstream [vulkan.h] hence we can drop the vulkan_intel.h ?
> Alternatively if there are no users for it we can drop the header and
> all the related code. Please ?

As side note, Android-IA Vulkan HAL is actively using this header and 
the function, please do not remove it before we have the upcoming 
extension for same functionality :)

// Tapani