[Mesa-dev] [RFC] glx: Prefer library path given by pkgconfig over the system

[Pohjolainen, Topi]

On Mon, Mar 20, 2017 at 11:03:48PM +0200, Grazvydas Ignotas wrote:
> On Mon, Mar 20, 2017 at 9:43 PM, Pohjolainen, Topi
> <topi.pohjolainen at gmail.com> wrote:
> > On Mon, Mar 20, 2017 at 04:45:22PM +0000, Emil Velikov wrote:
> >> On 20 March 2017 at 10:27, Grazvydas Ignotas <notasas at gmail.com> wrote:
> >> > On Mon, Mar 20, 2017 at 11:28 AM, Topi Pohjolainen
> >> > <topi.pohjolainen at gmail.com> wrote:
> >> >> Recent change to use drmGetDevices2() made me realize that
> >> >> build configured using
> >> >>
> >> >> PKG_CONFIG_PATH=my_drm_lib_path/pkgconfig ./autogen.sh
> >> >>
> >> >> considers the libdrm path gotten from pkgconfig only during
> >> >> make. When invoking "make install" the relink command puts
> >> >> system library ahead of the path gotten from pkgconfig
> >> >> (and starts to fail as system libdrm isn't new enough).
> >> >>
> >> >> This change forces the relink command to respect pkgconfig
> >> >> settings.
> >> >
> >> > Nice, this issue is really annoying, and using Emil's workarounds from
> >> > bug 100259 is cumbersome.
> >> Indeed they are - too many bugs to get around to sorting libtool, I'm afraid :-\
> >>
> >> > Tested-by: Grazvydas Ignotas <notasas at gmail.com>
> >> >
> >> >>
> >> >> It looks to me that in
> >> >>
> >> >> https://bugs.freedesktop.org/show_bug.cgi?id=100259
> >> >>
> >> >> Emil et al are discussing similar case with gbm.
> >> >>
> >> >> CC: Matt Turner <mattst88 at gmail.com>
> >> >> CC: Emil Velikov <emil.velikov at collabora.com>
> >> >> Signed-off-by: Topi Pohjolainen <topi.pohjolainen at intel.com>
> >> >> ---
> >> >>  src/glx/Makefile.am | 1 +
> >> >>  1 file changed, 1 insertion(+)
> >> >>
> >> >> diff --git a/src/glx/Makefile.am b/src/glx/Makefile.am
> >> >> index 79d416a..ced5227 100644
> >> >> --- a/src/glx/Makefile.am
> >> >> +++ b/src/glx/Makefile.am
> >> >> @@ -175,6 +175,7 @@ GL_LIB_VERSION=1:2
> >> >>  endif
> >> >>
> >> >>  GL_LIBS = \
> >> >> +       $(LIBDRM_LIBS) \
> >> If we are to do this, please add a comment - "HACK" or "W/A" with why
> >> we need it/how it works.
> >> This way we can purge it in a few months as distros catch up ;-)
> >
> > Shouldn't there be something of this sort in general? Build system should
> > respect the configuration gotten from pkgconfig, right?
> >
> > And isn't libdrm upstream almost always ahead of distros. Once distros reach
> > 2.4.75 libdrm, upstream is likely to have moved forward, don't you think?
> >
> > I can keep this patch in my private tree to make it work for me in case there
> > aren't other people needing it.
> 
> If I wasn't clear enough, there is at least one person.

Yep, and thanks for testing! I came up with a another less intrusive version.

> 
> Gra??vydas